MLE-24755 binary doc test fixes #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes two binary document test files by converting them from callback-based to async/await patterns and consolidating multiple test cases into single comprehensive tests.
Key Changes:
- Converted callback-based async code to modern async/await syntax
- Consolidated multiple separate test cases into single comprehensive test flows
- Changed from
removeAll()to targetedremove()for cleaner test isolation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test-complete/nodejs-documents-read-chunk.js | Modernized test to use async/await, consolidated write/read/verify/delete operations into a single test case |
| test-complete/nodejs-documents-binary-pdf.js | Converted to async/await pattern, merged separate test cases for write/read/metadata/delete into one comprehensive test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjrudin
previously approved these changes
Oct 20, 2025
stevebio
force-pushed
the
feature/MLE-24755-binary-doc-test-fixes
branch
from
f4ea9f1 to
1d50e90
Compare
rjrudin
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.